Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmake builds #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Nmake builds #29

wants to merge 3 commits into from

Conversation

apnadkarni
Copy link
Contributor

Fixes broken nmake builds wrt TIP445 as well as some VC++ issues. Passes all tests except failures in memory.test due to an inability to measure memory usage on Windows. In addition to build issues, have also modified C code for the following reasons:

  • VC++ does not accept {} as struct init - replaced with {0}
  • Fixed size_t -> int warnings with explicit casts
  • Changed %ld for printf with %zd for size_t arguments
  • Changed unsigned int to int in iterators to fix "signed/unsigned" warnings

Confirmed builds and passes tests with gcc on Ubuntu as well, except for memory-2.1 which was failing already (missing foreach_data directory)

Do not use empty initializers {}, use {0} instead.
Disable checkmem command for MSC_VER due to missing mkstemp function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant